Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14173 )
Change subject: IMPALA-8897 (part 2): Fix javascript to work with Knox integration ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/14173/1/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/14173/1/tests/webserver/test_web_pages.py@673 PS1, Line 673: regex = "(%s)|(%s)|(%s)" % (href_regex, form_regex, javascript_regex) > I missed this when reviewing the first patch, but it looks like the path is Done http://gerrit.cloudera.org:8080/#/c/14173/1/www/common-header.tmpl File www/common-header.tmpl: http://gerrit.cloudera.org:8080/#/c/14173/1/www/common-header.tmpl@76 PS1, Line 76: should > should Done http://gerrit.cloudera.org:8080/#/c/14173/1/www/common-header.tmpl@76 PS1, Line 76: compatibility > nit: compatibility Done -- To view, visit http://gerrit.cloudera.org:8080/14173 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3de9fd1bbb8bb38ce63b3160fcafd33eb0530581 Gerrit-Change-Number: 14173 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 05 Sep 2019 18:26:44 +0000 Gerrit-HasComments: Yes
