Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14175 )
Change subject: Fix statestored /rpcz page ...................................................................... Fix statestored /rpcz page This patch fixes two issues with the statestore's /rpcz debug webui page: - When the statestore was refactored in IMPALA-4784 to move the declaration of the creation of the ThriftServer from statestored-main.cc into the Statestore class, the TProcessor and TProcessorEventHandler in StatestoredMain() were accidentally left even though they are no longer being used. This resulted in there being two RpcEventHandlers with the server name 'statstore', which caused the json processing logic on the /rpcz page for the statstore to behave incorrectly. This patch removes the extra TProcessor. - Because the statestored does not currently have any krpc services, the json for its /rpcz page does not contain the 'services' field and refresh hits an error when trying to access it. This patch checks for this condition and skips updating the krpc services in this case. Testing: - Manually checked that the statestore's /rpcz page now works. Change-Id: Iaf01c3af219e17728836c63b1e0ff10cbcb221ff Reviewed-on: http://gerrit.cloudera.org:8080/14175 Reviewed-by: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M be/src/statestore/statestored-main.cc M www/rpcz.tmpl 2 files changed, 1 insertion(+), 6 deletions(-) Approvals: Thomas Tauber-Marshall: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/14175 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Iaf01c3af219e17728836c63b1e0ff10cbcb221ff Gerrit-Change-Number: 14175 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
