Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14188 )
Change subject: IMPALA-8923: remove synchronized in HBaseTable.getEstimatedRowStats ...................................................................... Patch Set 2: Code-Review+2 (3 comments) nice find. http://gerrit.cloudera.org:8080/#/c/14188/2/fe/src/main/java/org/apache/impala/catalog/FeHBaseTable.java File fe/src/main/java/org/apache/impala/catalog/FeHBaseTable.java: http://gerrit.cloudera.org:8080/#/c/14188/2/fe/src/main/java/org/apache/impala/catalog/FeHBaseTable.java@369 PS2, Line 369: LOG.trace(String.format("getEstimatedRowStats for %s from %s to %s", nit: use parameterized logging, {}... http://gerrit.cloudera.org:8080/#/c/14188/2/fe/src/main/java/org/apache/impala/catalog/FeHBaseTable.java@438 PS2, Line 438: if (LOG.isTraceEnabled()) { same. Probably helps to dump the timetaken too. http://gerrit.cloudera.org:8080/#/c/14188/2/fe/src/main/java/org/apache/impala/catalog/FeHBaseTable.java@652 PS2, Line 652: LOG.trace("getRegionsInRange"); intentional? -- To view, visit http://gerrit.cloudera.org:8080/14188 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifa23c16ee662c4f22851c700aea2ea5be847b64d Gerrit-Change-Number: 14188 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Fri, 06 Sep 2019 18:53:53 +0000 Gerrit-HasComments: Yes
