Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14185 )
Change subject: IMPALA-8921: Use short name for Ranger grant/revoke requests ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/14185/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14185/1//COMMIT_MSG@7 PS1, Line 7: User > typo? Use? Done http://gerrit.cloudera.org:8080/#/c/14185/1/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java: http://gerrit.cloudera.org:8080/#/c/14185/1/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java@126 PS1, Line 126: new User(header.getRequesting_user()).getShortName(), true, params.getPrincipal_name(), > line too long (95 > 90) Done http://gerrit.cloudera.org:8080/#/c/14185/1/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java@138 PS1, Line 138: new User(header.getRequesting_user()).getShortName(), false, params.getPrincipal_name(), > line too long (96 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/14185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3dc1bf55d50dc2e5fa6e07f16644f0a2773f2d23 Gerrit-Change-Number: 14185 Gerrit-PatchSet: 1 Gerrit-Owner: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Austin Nobis <ano...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Sat, 07 Sep 2019 19:17:28 +0000 Gerrit-HasComments: Yes