Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/13940 )
Change subject: IMPALA-5031: widen Thrift enum to placate UBSAN ...................................................................... Patch Set 1: > I'm a bit reluctant about diverging parquet.thrift from the > upstream Apache Parquet thrift. Need to think about whether this is > the right way. We actually already deviated in the encoding. That kind of deviation or this one are the two ways that occurred to me to resolve issues like this. Did you have any other particular method in mind? -- To view, visit http://gerrit.cloudera.org:8080/13940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48090e8e0c6c6f18bb1ad3c32c1f5fbffc908844 Gerrit-Change-Number: 13940 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple <jbap...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbap...@apache.org> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Sun, 08 Sep 2019 18:32:37 +0000 Gerrit-HasComments: No
