Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14181 )

Change subject: IMPALA-1071: Distributable python package for impala-shell
......................................................................


Patch Set 3: Code-Review+1

(2 comments)

Thanks for making this!

http://gerrit.cloudera.org:8080/#/c/14181/3/shell/impala_client.py
File shell/impala_client.py:

http://gerrit.cloudera.org:8080/#/c/14181/3/shell/impala_client.py@1120
PS3, Line 1120: th
nit: typo


http://gerrit.cloudera.org:8080/#/c/14181/3/shell/packaging/make_python_package.sh
File shell/packaging/make_python_package.sh:

http://gerrit.cloudera.org:8080/#/c/14181/3/shell/packaging/make_python_package.sh@37
PS3, Line 37:
nit: remove space



--
To view, visit http://gerrit.cloudera.org:8080/14181
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8c745bddddf6a16f0c039430152745a2f00e044
Gerrit-Change-Number: 14181
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dkn...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com>
Gerrit-Reviewer: David Knupp <dkn...@cloudera.com>
Gerrit-Reviewer: David Rorke <dro...@cloudera.com>
Gerrit-Reviewer: Dinesh Garg (430)
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Sep 2019 16:16:24 +0000
Gerrit-HasComments: Yes

Reply via email to