Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14157 )
Change subject: IMPALA-7312: Non-blocking mode for Fetch() RPC ...................................................................... Patch Set 9: @Tim, think I might need another review on this one. The test failures in the pre-commit job were legit. The fix is pretty simple, see the change to expr-test.cc. I noticed a few other odd things while testing this though, so had to make the following changes: * Before the latest patch, if result spooling was disabled, the timeout applied to both the time taking for the fragment thread to send rows AND the time taken to materialize rows. If result spooling was disabled, it was only applied to the time taken for the fragment thread to send rows. The latest patch fixes that, and I added another test for it as well. * I started seeing duplicate entries for "First row fetched" in the profile; it looks like the current code emits "First row fetched" whenever ImpalaServer::FetchInternal is called and 0 rows have been fetched. The issue is that with the timeout, it is not possible for a fetch request to return 0 rows, and for more rows to be available. Fixed this by moving the "First row fetched" event to "Coordinator::GetNext". -- To view, visit http://gerrit.cloudera.org:8080/14157 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I331acaba23a65dab43cca48e9dc0dc957b9c632d Gerrit-Change-Number: 14157 Gerrit-PatchSet: 9 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 09 Sep 2019 17:12:39 +0000 Gerrit-HasComments: No
