Hello Michael Ho, Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14180
to look at the new patch set (#2).
Change subject: IMPALA-8825: Add additional counters to PlanRootSink
......................................................................
IMPALA-8825: Add additional counters to PlanRootSink
Adds the counters RowsSent and RowsSentRate to the PLAN_ROOT_SINK
section of the profile:
PLAN_ROOT_SINK:
- PeakMemoryUsage: 4.01 MB (4202496)
- RowBatchGetWaitTime: 0.000ns
- RowBatchSendWaitTime: 0.000ns
- RowsSent: 10 (10)
- RowsSentRate: 416.00 /sec
RowsSent tracks the number of rows sent to the PlanRootSink via
PlanRootSink::Send. RowsSentRate tracks the rate that rows are sent to
the PlanRootSink.
Adds the counters NumRowsFetched, RowMaterializationRate, and
RowsMaterialized to the ImpalaServer section of the profile.
ImpalaServer:
- ClientFetchWaitTimer: 11.999ms
- NumRowsFetched: 10 (10)
- RowMaterializationRate: 9.00 /sec
- RowMaterializationTimer: 1s007ms
- RowsMaterialized: 10 (10)
NumRowsFetched tracks the total number of rows fetched by the query,
including rows fetched from the cache. RowMaterializationRate tracks the
rate at which rows are materialized and RowsMaterialized tracks the
number of rows materialized (RowMaterializationTimer already existed and
tracks how much time is spent materializing rows).
NumRowsFetched and RowsMaterialized track similar but distinct values.
NumRowsFetched tracks the number of rows read, including any rows read
from the query results cache, whereas RowsMaterialized does not track
rows read from the query results cache. NumRowsFetched will be greater
than RowsMaterialized if the read cursor is reset (e.g
TCLIService.TFetchOrientation.FETCH_FIRST is used).
Testing:
* Added tests to test_fetch_first.py and query_test/test_fetch.py
* Enabled some tests in test_fetch_first.py that were pending
the completion of IMPALA-8819
* Ran core tests
Change-Id: Id9e101e2f3e2bf8324e149c780d35825ceecc036
---
M be/src/exec/blocking-plan-root-sink.cc
M be/src/exec/buffered-plan-root-sink.cc
M be/src/exec/plan-root-sink.cc
M be/src/exec/plan-root-sink.h
M be/src/service/client-request-state.cc
M be/src/service/client-request-state.h
M tests/common/impala_test_suite.py
M tests/custom_cluster/test_result_spooling.py
M tests/hs2/test_fetch_first.py
A tests/query_test/test_fetch.py
10 files changed, 200 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/14180/2
--
To view, visit http://gerrit.cloudera.org:8080/14180
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id9e101e2f3e2bf8324e149c780d35825ceecc036
Gerrit-Change-Number: 14180
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <stak...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
