Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14203 )
Change subject: IMPALA-8933: Enforce ranger deny policy ...................................................................... Patch Set 6: (10 comments) http://gerrit.cloudera.org:8080/#/c/14203/6/fe/src/main/java/org/apache/impala/authorization/BaseAuthorizationChecker.java File fe/src/main/java/org/apache/impala/authorization/BaseAuthorizationChecker.java: http://gerrit.cloudera.org:8080/#/c/14203/6/fe/src/main/java/org/apache/impala/authorization/BaseAuthorizationChecker.java@234 PS6, Line 234: // In order to support deny policies on columns tab used for whitespace http://gerrit.cloudera.org:8080/#/c/14203/6/fe/src/main/java/org/apache/impala/authorization/BaseAuthorizationChecker.java@235 PS6, Line 235: if (hasTableSelectPriv && tab used for whitespace http://gerrit.cloudera.org:8080/#/c/14203/6/fe/src/main/java/org/apache/impala/authorization/BaseAuthorizationChecker.java@236 PS6, Line 236: request.getPrivilege() != Privilege.SELECT && tab used for whitespace http://gerrit.cloudera.org:8080/#/c/14203/6/fe/src/main/java/org/apache/impala/authorization/BaseAuthorizationChecker.java@237 PS6, Line 237: request.getPrivilege() != Privilege.INSERT) { tab used for whitespace http://gerrit.cloudera.org:8080/#/c/14203/6/fe/src/main/java/org/apache/impala/authorization/BaseAuthorizationChecker.java@238 PS6, Line 238: continue; tab used for whitespace http://gerrit.cloudera.org:8080/#/c/14203/6/fe/src/main/java/org/apache/impala/authorization/BaseAuthorizationChecker.java@239 PS6, Line 239: } tab used for whitespace http://gerrit.cloudera.org:8080/#/c/14203/6/fe/src/main/java/org/apache/impala/authorization/BaseAuthorizationChecker.java@240 PS6, Line 240: if (hasAccess(authzCtx, analyzer.getUser(), request)) { tab used for whitespace http://gerrit.cloudera.org:8080/#/c/14203/6/fe/src/main/java/org/apache/impala/authorization/BaseAuthorizationChecker.java@241 PS6, Line 241: hasColumnSelectPriv = true; tab used for whitespace http://gerrit.cloudera.org:8080/#/c/14203/6/fe/src/main/java/org/apache/impala/authorization/BaseAuthorizationChecker.java@242 PS6, Line 242: continue; tab used for whitespace http://gerrit.cloudera.org:8080/#/c/14203/6/fe/src/main/java/org/apache/impala/authorization/BaseAuthorizationChecker.java@243 PS6, Line 243: } tab used for whitespace -- To view, visit http://gerrit.cloudera.org:8080/14203 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic60786cd81080feeb0bfcd92aa2be646ee8cb7da Gerrit-Change-Number: 14203 Gerrit-PatchSet: 6 Gerrit-Owner: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 11 Sep 2019 00:10:31 +0000 Gerrit-HasComments: Yes