Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 )
Change subject: IMPALA-8572: Log query events before unregister. ...................................................................... Patch Set 12: Code-Review+2 (1 comment) Carrying +2. I've spent some time on the patch to see what could be wrong with synchronization but I didn't see anything wrong. Also, interestingly the tests started working in the last 2 runs. I'll try to get this in for now. Will revert and dig into it if we run into any issues in the builds. http://gerrit.cloudera.org:8080/#/c/14143/11/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/14143/11/be/src/service/client-request-state.cc@780 PS11, Line 780: // Some metadata operations like GET_COLUMNS do not rely on WaitAsync() to launch > Do we need the wait_thread_ check though? Since after the wait thread is de Like we discussed, some codepaths like metadata op requests do not launch the async wait thread but still BlockOnWait() during fetches. In such cases the condition guards them from blocking forever. We can probably refactor the code better to make the metadata ops act like regular query paths. For now, I added a comment. -- To view, visit http://gerrit.cloudera.org:8080/14143 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I639b9c1acb9806b29292cd85be2863688453ca2e Gerrit-Change-Number: 14143 Gerrit-PatchSet: 12 Gerrit-Owner: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: radford nguyen <radford.ngu...@gmail.com> Gerrit-Comment-Date: Wed, 11 Sep 2019 21:51:06 +0000 Gerrit-HasComments: Yes
