Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14213 )
Change subject: IMPALA-8940: Fix MetastoreEventsProcessorTest.testPartitionEvents in CDP builds ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Carry +2 http://gerrit.cloudera.org:8080/#/c/14213/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/14213/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1382 PS1, Line 1382: if (val == null) { > nit: formatting, don't think we use single line if else Done -- To view, visit http://gerrit.cloudera.org:8080/14213 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie93e7237944142f616a80dec675280b397fe5995 Gerrit-Change-Number: 14213 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Thu, 12 Sep 2019 09:04:00 +0000 Gerrit-HasComments: Yes
