Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/14080 )
Change subject: IMPALA-8755: Backend support for Z-ordering ...................................................................... Patch Set 8: (7 comments) http://gerrit.cloudera.org:8080/#/c/14080/7/be/src/util/tuple-row-compare-test.cc File be/src/util/tuple-row-compare-test.cc: http://gerrit.cloudera.org:8080/#/c/14080/7/be/src/util/tuple-row-compare-test.cc@94 PS7, Line 94: Tuple* tuple_mem = Tuple::Create(sizeof(char) + GetSize(args...), &expr_perm_pool_); > line too long (92 > 90) Done http://gerrit.cloudera.org:8080/#/c/14080/5/be/src/util/tuple-row-compare.cc File be/src/util/tuple-row-compare.cc: http://gerrit.cloudera.org:8080/#/c/14080/5/be/src/util/tuple-row-compare.cc@314 PS5, Line 314: > nit: Can we come up with a better name? Maybe GetZDimensionValue() or somet Done http://gerrit.cloudera.org:8080/#/c/14080/5/be/src/util/tuple-row-compare.cc@334 PS5, Line 334: turn Comp > Maybe you could add a DCHECK(false); as well, and maybe a TODO comment. If Done http://gerrit.cloudera.org:8080/#/c/14080/5/be/src/util/tuple-row-compare.cc@383 PS5, Line 383: rn > nit: since you use 'lhs' and 'rhs' at other places, maybe rename 'v1' and ' Done http://gerrit.cloudera.org:8080/#/c/14080/7/be/src/util/tuple-row-compare.cc File be/src/util/tuple-row-compare.cc: http://gerrit.cloudera.org:8080/#/c/14080/7/be/src/util/tuple-row-compare.cc@209 PS7, Line 209: Status TupleRowLexicalComparator::CodegenCompare(LlvmCodeGen* codegen, > line too long (93 > 90) Done http://gerrit.cloudera.org:8080/#/c/14080/7/be/src/util/tuple-row-compare.cc@323 PS7, Line 323: constexpr uint64_t mask64 = 0x8000000000000000; > line too long (95 > 90) Done http://gerrit.cloudera.org:8080/#/c/14080/7/be/src/util/tuple-row-compare.cc@395 PS7, Line 395: case TYPE_TIMESTAMP: { > line too long (91 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/14080 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0200748ce3e65ebc5d3530f794c0f80aa335a2ab Gerrit-Change-Number: 14080 Gerrit-PatchSet: 8 Gerrit-Owner: Norbert Luksa <norbert.lu...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Norbert Luksa <norbert.lu...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 13 Sep 2019 12:58:41 +0000 Gerrit-HasComments: Yes
