Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14246 )
Change subject: IMPALA-8634: Catalog client should retry RPCs ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/14246/1/be/src/exec/catalog-op-executor.cc File be/src/exec/catalog-op-executor.cc: http://gerrit.cloudera.org:8080/#/c/14246/1/be/src/exec/catalog-op-executor.cc@62 PS1, Line 62: static Status CatalogRpcDebugFn(int& attempt) { nit: pass as a pointer http://gerrit.cloudera.org:8080/#/c/14246/1/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: http://gerrit.cloudera.org:8080/#/c/14246/1/be/src/runtime/exec-env.cc@142 PS1, Line 142: DEFINE_int32(catalog_client_connection_num_retries, 3, "The number of times connections " I kinda wonder if we should tweak the defaults to make it poll more frequently and/or longer. Every 10 seconds seems kinda long if the outage might be intermittent flakiness. 30 seconds also might not be long enough for the catalogd to recover (although I can see we might just want to fail queries if they're delayed 30+ seconds). -- To view, visit http://gerrit.cloudera.org:8080/14246 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f33ad2b36d301fb64e70a939e71decab0ca993c Gerrit-Change-Number: 14246 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 17 Sep 2019 20:43:10 +0000 Gerrit-HasComments: Yes
