Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 )
Change subject: IMPALA-7637: Add more hash table stats to profile ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/14234/2/be/src/exec/hash-table.cc File be/src/exec/hash-table.cc: http://gerrit.cloudera.org:8080/#/c/14234/2/be/src/exec/hash-table.cc@425 PS2, Line 425: statsProfile->num_hash_collisions_ = ADD_COUNTER(hashtable_profile, "HashCollisions", TUnit::UNIT); line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/14234/2/be/src/exec/hash-table.cc@426 PS2, Line 426: statsProfile->num_hash_buckets_ = ADD_COUNTER(hashtable_profile, "HashBuckets", TUnit::UNIT); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/14234/2/be/src/exec/hash-table.cc@427 PS2, Line 427: statsProfile->num_hash_resizes_ = ADD_COUNTER(hashtable_profile, "Resizes", TUnit::UNIT); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/14234/2/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/14234/2/tests/query_test/test_observability.py@677 PS2, Line 677: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/14234/2/tests/query_test/test_observability.py@677 PS2, Line 677: # Probes and travel can be 0. The number can be a integer or float with K line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/14234/2/tests/query_test/test_observability.py@683 PS2, Line 683: " flake8: E501 line too long (91 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/14234 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1fd875dd1af8031242fd5f5ff554d3a71aaa6f87 Gerrit-Change-Number: 14234 Gerrit-PatchSet: 2 Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com> Gerrit-Comment-Date: Wed, 18 Sep 2019 12:48:13 +0000 Gerrit-HasComments: Yes
