Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14240 )
Change subject: IMPALA-8761: Improve events processor configuration validation. ...................................................................... Patch Set 2: Code-Review+2 (4 comments) http://gerrit.cloudera.org:8080/#/c/14240/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14240/2//COMMIT_MSG@9 PS2, Line 9: This patch aims to improve the validation of configuration keys from the HMS. nit: line wrap http://gerrit.cloudera.org:8080/#/c/14240/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/14240/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@267 PS2, Line 267: failedValidationResults nit: validationErrors? http://gerrit.cloudera.org:8080/#/c/14240/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@273 PS2, Line 273: if (!result.isValid()) { nit: single line. http://gerrit.cloudera.org:8080/#/c/14240/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@282 PS2, Line 282: failedValidationResults.size() > 0 nit: !validationErrors.isEmpty() (more concise) -- To view, visit http://gerrit.cloudera.org:8080/14240 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73480872ef93215d05c1fd922e64eb68a8a63a42 Gerrit-Change-Number: 14240 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Wed, 18 Sep 2019 18:50:25 +0000 Gerrit-HasComments: Yes
