Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/6521 )
Change subject: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so ...................................................................... IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so C++ packages depend on these shared objects. Our toolchain packages should always be run using the toolchain version of the shared objects that it ships. Previously the toolchain artifacts were often (but not always) linked against system version of libgcc.so and libstdc++.so, which can cause compatibility problems. This is a major problem on recent Linux distros like Ubuntu 16.04 that default to the new C++11 ABI because the system libstdc++.so is not compatible with gcc-4.9.2-generated binaries. It also means behaviour of toolchain artifacts may be less consistent across systems. This patch does two things to ensure that toolchain artifacts link to the correct libraries: 1. fixes the RPATHs added to executables and shared objects so that they always point to the ../lib/ and ../lib64/ directories. 2. adds symlinks from the lib/ directory to libstd++.so and libgcc.so where required by executables and shared objects. Also remove redundant ccache enablement in the cmake build scripts. We already use ccache globally via a wrapper script. Change-Id: Ie3f8481a8dfe35273a763586e9d2da0d4008ac67 Reviewed-on: http://gerrit.cloudera.org:8080/6521 Reviewed-by: Joe McDonnell <joemcdonn...@cloudera.com> Tested-by: Tim Armstrong <tarmstr...@cloudera.com> --- M functions.sh M init-compiler.sh M source/cmake/build.sh M source/flatbuffers/build.sh M source/kudu/build.sh M source/llvm/build.sh M source/protobuf/build.sh M source/thrift/build.sh 8 files changed, 136 insertions(+), 11 deletions(-) Approvals: Joe McDonnell: Looks good to me, approved Tim Armstrong: Verified -- To view, visit http://gerrit.cloudera.org:8080/6521 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie3f8481a8dfe35273a763586e9d2da0d4008ac67 Gerrit-Change-Number: 6521 Gerrit-PatchSet: 14 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Hector Acosta <hector.aco...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
