Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14242 )
Change subject: IMPALA-8884: track storage read statistics per queue ...................................................................... Patch Set 1: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/14242/1/be/src/runtime/io/disk-io-mgr.cc File be/src/runtime/io/disk-io-mgr.cc: http://gerrit.cloudera.org:8080/#/c/14242/1/be/src/runtime/io/disk-io-mgr.cc@278 PS1, Line 278: 1000L * 1000L * 1000L NANOS_PER_SEC http://gerrit.cloudera.org:8080/#/c/14242/1/be/src/runtime/io/local-file-reader.h File be/src/runtime/io/local-file-reader.h: http://gerrit.cloudera.org:8080/#/c/14242/1/be/src/runtime/io/local-file-reader.h@28 PS1, Line 28: public: nit: fix the indent here too http://gerrit.cloudera.org:8080/#/c/14242/1/be/src/runtime/io/local-file-reader.cc File be/src/runtime/io/local-file-reader.cc: http://gerrit.cloudera.org:8080/#/c/14242/1/be/src/runtime/io/local-file-reader.cc@64 PS1, Line 64: queue->read_size()->Update(bytes_to_read); Should we only update read_size() below near where read_timer is in case we hit various errors below ? http://gerrit.cloudera.org:8080/#/c/14242/1/be/src/runtime/io/local-file-reader.cc@76 PS1, Line 76: Substitute("Could not seek to $0 " : "for file: $1: $2", one line -- To view, visit http://gerrit.cloudera.org:8080/14242 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8233ed02b418f22f1d0c031e378288357796f4b4 Gerrit-Change-Number: 14242 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Comment-Date: Fri, 20 Sep 2019 23:38:01 +0000 Gerrit-HasComments: Yes
