Hello Michael Ho, Thomas Tauber-Marshall, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14275 to look at the new patch set (#3). Change subject: IMPALA-8926, IMPALA-8957: Fix result spooling flaky tests ...................................................................... IMPALA-8926, IMPALA-8957: Fix result spooling flaky tests TestResultSpooling::_test_full_queue was flaky because there was a race condition in the test where the result spooling queue would not fill up quickly enough. The original way around this was to sleep for a fixed amount of time in hope that the queue would fill up by the time the thread woke up. The new approach periodically searches the runtime profile for specific patterns that indicate the queue is full. TestFetchAndSpooling.test_rows_sent_counters was flaky because the RowsSentRate can be 0 if the results are spooled fast enough (because the time spent spooling results is 0). The fix is to use the DEBUG_ACTION BPRS_BEFORE_ADD_BATCH to introduce a delay when spooling results, so that the RowsSentRate is guaranteed to be non-zero. TestFetch.test_rows_sent_counters was flaky because ClientFetchWaitTimer can be 0 if the Coordinator does not end up waiting any time for results to be fetched. The fix is to wait until the query has 'FINISHED' (results are available to fetch) and then sleep so that the ClientFetchWaitTimer is a non-zero value. Cleaned up a few other tests as well. Testing: * Looped both tests for a few hours without failure Change-Id: I3042f592bc79785e43ebc7b09ac1270eae8ed66f --- M be/src/exec/blocking-plan-root-sink.cc M tests/query_test/test_fetch.py M tests/query_test/test_result_spooling.py 3 files changed, 54 insertions(+), 25 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/14275/3 -- To view, visit http://gerrit.cloudera.org:8080/14275 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3042f592bc79785e43ebc7b09ac1270eae8ed66f Gerrit-Change-Number: 14275 Gerrit-PatchSet: 3 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com>