Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 )
Change subject: IMPALA-7637: Add more hash table stats to profile ...................................................................... Patch Set 3: (2 comments) LGTM pending the test updates / doc updates. http://gerrit.cloudera.org:8080/#/c/14234/3/be/src/exec/hash-table.h File be/src/exec/hash-table.h: http://gerrit.cloudera.org:8080/#/c/14234/3/be/src/exec/hash-table.h@651 PS3, Line 651: StatsCountersAdd > I do not know the code well, but from what I read, When spill or serializes I'm not that familiar with this code either, but that makes sense. Would be good to make that a little clearer in the comments. Otherwise, LGTM. http://gerrit.cloudera.org:8080/#/c/14234/3/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/14234/3/tests/query_test/test_observability.py@676 PS3, Line 676: '(?<=Probes: )\d+(\.\d+)?' > I feel my approach is more strict, it requires the number must directly fol So does 'Probes:.*\((\d+)\)', positive look-behinds are useful when you need to use a regex to match a string that precedes another regex - https://www.regular-expressions.info/lookaround.html In this case, it is not necessary, because you can exactly match the entire string that precedes the numeric values, 'Probes: '. -- To view, visit http://gerrit.cloudera.org:8080/14234 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1fd875dd1af8031242fd5f5ff554d3a71aaa6f87 Gerrit-Change-Number: 14234 Gerrit-PatchSet: 3 Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com> Gerrit-Comment-Date: Tue, 24 Sep 2019 15:03:34 +0000 Gerrit-HasComments: Yes