Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13882 )
Change subject: IMPALA-7984: Port runtime filter from Thrift RPC to KRPC ...................................................................... Patch Set 22: (1 comment) http://gerrit.cloudera.org:8080/#/c/13882/22/be/src/util/bloom-filter.h File be/src/util/bloom-filter.h: http://gerrit.cloudera.org:8080/#/c/13882/22/be/src/util/bloom-filter.h@46 PS22, Line 46: namespace bloom_filter_test_util { : void BfUnion(const impala::BloomFilter& x, const impala::BloomFilter& y, : int64_t directory_size, bool* success, impala::BloomFilterPB* protobuf, : std::string* directory); : } // namespace bloom_filter_test_util : : namespace either { : struct TestData; : } // namespace either > Can these be moved to the test file ? I guess not. Sorry for missing the friend declaration below. -- To view, visit http://gerrit.cloudera.org:8080/13882 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b394796d250286510e157ae326882bfc01d387a Gerrit-Change-Number: 13882 Gerrit-PatchSet: 22 Gerrit-Owner: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Tue, 24 Sep 2019 17:52:24 +0000 Gerrit-HasComments: Yes
