Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14293 )
Change subject: IMPALA-2312: simplify stopwatch ElapsedTime() ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/14293/1/be/src/util/stopwatch.h File be/src/util/stopwatch.h: http://gerrit.cloudera.org:8080/#/c/14293/1/be/src/util/stopwatch.h@116 PS1, Line 116: void Stop() { : total_time_ += RunningTime(); : running_ = false; : } nit, consistancy: this and StopWatch's stop seem to to exactly the same, as RunningTime() returns 0 is running_ is false. I think that it would be better if both would be the same, as people would not start looking for differences :) -- To view, visit http://gerrit.cloudera.org:8080/14293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I004833681248de65ce709fc746269686507aba54 Gerrit-Change-Number: 14293 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Thu, 26 Sep 2019 14:15:06 +0000 Gerrit-HasComments: Yes
