Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13329 )
Change subject: IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader ...................................................................... IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader Moved some responsibilities from parquet-column-readers.cc to new classes 'ParquetColumnChunkReader' and 'ParquetPageReader': - reading pages from ScanRange - decompress data if needed The main motivation is to make the implementation of V2 data page reading simpler by moving most parts that will differ between V1 and V2 into a class with manageable complexity. Testing: - ran parquet related scanner tests Change-Id: Ic0289394adcb97a3529313030930c9c5b85aaa12 Reviewed-on: http://gerrit.cloudera.org:8080/13329 Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Reviewed-by: Csaba Ringhofer <csringho...@cloudera.com> --- M be/src/exec/parquet/CMakeLists.txt M be/src/exec/parquet/hdfs-parquet-scanner.h A be/src/exec/parquet/parquet-column-chunk-reader.cc A be/src/exec/parquet/parquet-column-chunk-reader.h M be/src/exec/parquet/parquet-column-readers.cc M be/src/exec/parquet/parquet-column-readers.h A be/src/exec/parquet/parquet-page-reader.cc A be/src/exec/parquet/parquet-page-reader.h 8 files changed, 971 insertions(+), 503 deletions(-) Approvals: Impala Public Jenkins: Verified Csaba Ringhofer: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/13329 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic0289394adcb97a3529313030930c9c5b85aaa12 Gerrit-Change-Number: 13329 Gerrit-PatchSet: 27 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com>
