Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13942 )
Change subject: IMPALA-8451: enable admission control for dockerised tests ...................................................................... Patch Set 17: (5 comments) http://gerrit.cloudera.org:8080/#/c/13942/16/be/src/scheduling/admission-controller.h File be/src/scheduling/admission-controller.h: http://gerrit.cloudera.org:8080/#/c/13942/16/be/src/scheduling/admission-controller.h@943 PS16, Line 943: Return > Mention the unit in the comment, and possibly in the name, e.g. GetQueueTim Done http://gerrit.cloudera.org:8080/#/c/13942/16/common/thrift/metrics.json File common/thrift/metrics.json: http://gerrit.cloudera.org:8080/#/c/13942/16/common/thrift/metrics.json@58 PS16, Line 58: "units": "TIME_MS", > Should the unit be TIME_MS? Done http://gerrit.cloudera.org:8080/#/c/13942/16/testdata/workloads/functional-query/queries/QueryTest/large_strings.test File testdata/workloads/functional-query/queries/QueryTest/large_strings.test: http://gerrit.cloudera.org:8080/#/c/13942/16/testdata/workloads/functional-query/queries/QueryTest/large_strings.test@185 PS16, Line 185: set mem_limit=5gb; > Typo? Or did this test just happen to require 1gb more memory? Yeah it OOMs with 4GB of memory. http://gerrit.cloudera.org:8080/#/c/13942/16/testdata/workloads/functional-query/queries/QueryTest/spilling-large-rows.test File testdata/workloads/functional-query/queries/QueryTest/spilling-large-rows.test: http://gerrit.cloudera.org:8080/#/c/13942/16/testdata/workloads/functional-query/queries/QueryTest/spilling-large-rows.test@60 PS16, Line 60: set mem_limit="1gb"; > nit: some tests in this file specify "1g", others "1gb". Unify them? Some of them needed to be quoted because of quirks in the grammar, so quoted them all. http://gerrit.cloudera.org:8080/#/c/13942/16/tests/query_test/test_insert.py File tests/query_test/test_insert.py: http://gerrit.cloudera.org:8080/#/c/13942/16/tests/query_test/test_insert.py@89 PS16, Line 89: 4g > nit: 4gb? Done -- To view, visit http://gerrit.cloudera.org:8080/13942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7517673f9e348780fcf7cd6ce1f12c9c5a55373a Gerrit-Change-Number: 13942 Gerrit-PatchSet: 17 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 26 Sep 2019 17:53:22 +0000 Gerrit-HasComments: Yes
