Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14318 )
Change subject: Remove hard-coded localhost from impala_test_suite.py ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14318/1/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/14318/1/tests/common/impala_test_suite.py@128 PS1, Line 128: impalad_hostname = pytest.config.option.impalad.split(',')[0].split(':')[0] IMPALAD_HOSTNAME? Also, maybe better to combine this with the stuff above to reduce duplication, i.e. define IMPALAD_HOSTNAME immediately after IMPALAD above, and then use it when constructing IMPALAD_HS2_HOST_PORT, etc. -- To view, visit http://gerrit.cloudera.org:8080/14318 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c52d94d9876661faada42d6570ef5005960e74d Gerrit-Change-Number: 14318 Gerrit-PatchSet: 1 Gerrit-Owner: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 27 Sep 2019 22:52:20 +0000 Gerrit-HasComments: Yes
