Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14264 )
Change subject: IMPALA-8498: Write column index for floating types when NaN is not present ...................................................................... Patch Set 5: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/14264/5/be/src/exec/parquet/hdfs-parquet-table-writer.cc File be/src/exec/parquet/hdfs-parquet-table-writer.cc: http://gerrit.cloudera.org:8080/#/c/14264/5/be/src/exec/parquet/hdfs-parquet-table-writer.cc@473 PS5, Line 473: typename std::remove_cv<T>::type nit: can be shortened to 'std::remove_cv_t<T>' http://gerrit.cloudera.org:8080/#/c/14264/5/tests/query_test/test_parquet_page_index.py File tests/query_test/test_parquet_page_index.py: http://gerrit.cloudera.org:8080/#/c/14264/5/tests/query_test/test_parquet_page_index.py@461 PS5, Line 461: FLOAT", "DOUBLE you can use lower cased 'float' and 'double', the CAST below will work just fine. And you won't need to call 'lower()' all the time. http://gerrit.cloudera.org:8080/#/c/14264/5/tests/query_test/test_parquet_page_index.py@475 PS5, Line 475: " nit: you could add '_' here and below -- To view, visit http://gerrit.cloudera.org:8080/14264 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9d367500243c8ca142a16ebfeef6c841f013434 Gerrit-Change-Number: 14264 Gerrit-PatchSet: 5 Gerrit-Owner: Norbert Luksa <norbert.lu...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Norbert Luksa <norbert.lu...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 03 Oct 2019 12:29:12 +0000 Gerrit-HasComments: Yes
