Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14363 )
Change subject: IMPALA-9005: distcc server bootstrapping improvements ...................................................................... Patch Set 1: (4 comments) Thanks for the review. This is kinda raw and might not handle a bunch of edge cases, but wanted to get it checked in at least instead of sitting around on my own system. http://gerrit.cloudera.org:8080/#/c/14363/1/bin/distcc/distcc_server_bootstrap.sh File bin/distcc/distcc_server_bootstrap.sh: http://gerrit.cloudera.org:8080/#/c/14363/1/bin/distcc/distcc_server_bootstrap.sh@26 PS1, Line 26: Arguments are forwarded to : # distcc_server_setup.sh to specify IP ranges, etc. > Nit: Are we ok with the defaults for CCACHE_DIR/CCACHE_SIZE that are set in Added a mention. I didn't want to re-document those options so I made the explanation generic. http://gerrit.cloudera.org:8080/#/c/14363/1/bin/distcc/distcc_server_bootstrap.sh@43 PS1, Line 43: fi > Will add an else that fails the script. Done http://gerrit.cloudera.org:8080/#/c/14363/1/bin/distcc/distcc_server_bootstrap.sh@62 PS1, Line 62: # Set HOME as workaround for ccache trying to access /.ccache : HOME=$(pwd) > To check my understanding: this is ccache usage from these setup commands a Done. Updated the comment to explain better http://gerrit.cloudera.org:8080/#/c/14363/1/bin/distcc/distcc_server_bootstrap.sh@70 PS1, Line 70: . bin/impala-config.sh : ./infra/python/deps/download_requirements : DOWNLOAD_CDH_COMPONENTS=false ./bin/bootstrap_toolchain.py > Super-nit: indentation here is a single space, but it should be two spaces Done -- To view, visit http://gerrit.cloudera.org:8080/14363 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e382e90f68a5a2fe2917184fa4603bed492a308 Gerrit-Change-Number: 14363 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 03 Oct 2019 23:23:36 +0000 Gerrit-HasComments: Yes
