Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14397 )
Change subject: IMPALA-9030: Handle translated external Kudu tables ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/14397/3/fe/src/main/java/org/apache/impala/catalog/KuduTable.java File fe/src/main/java/org/apache/impala/catalog/KuduTable.java: http://gerrit.cloudera.org:8080/#/c/14397/3/fe/src/main/java/org/apache/impala/catalog/KuduTable.java@134 PS3, Line 134: a nit: an http://gerrit.cloudera.org:8080/#/c/14397/3/fe/src/main/java/org/apache/impala/catalog/KuduTable.java@142 PS3, Line 142: isExternalTable(msTbl) && !Boolean : .parseBoolean(msTbl.getParameters().get(TBL_PROP_EXTERNAL_TABLE_PURGE)); This should be reversed now, since a synchronized table is either managed or has the purge option set to true, right? -- To view, visit http://gerrit.cloudera.org:8080/14397 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I324523361c923b7d291cb4d0f1028b1a5b653b36 Gerrit-Change-Number: 14397 Gerrit-PatchSet: 3 Gerrit-Owner: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Greg Solovyev <gsolov...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Tue, 15 Oct 2019 00:56:05 +0000 Gerrit-HasComments: Yes
