Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14444 )

Change subject: WIP: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
......................................................................


Patch Set 1:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/14444/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java
File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java:

http://gerrit.cloudera.org:8080/#/c/14444/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@723
PS1, Line 723:           LOG.info("Txn id (" + Long.toString(txnId) + ") lock " 
+ Long.toString(lockId) + " is busy, waiting " +
line too long (113 > 90)


http://gerrit.cloudera.org:8080/#/c/14444/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/14444/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1917
PS1, Line 1917:           throw new InternalException(String.format("Error 
truncating table %s due to lock " +
line too long (94 > 90)


http://gerrit.cloudera.org:8080/#/c/14444/1/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:

http://gerrit.cloudera.org:8080/#/c/14444/1/tests/common/impala_test_suite.py@219
PS1, Line 219: #
flake8: E265 block comment should start with '# '


http://gerrit.cloudera.org:8080/#/c/14444/1/tests/stress/test_acid_stress.py
File tests/stress/test_acid_stress.py:

http://gerrit.cloudera.org:8080/#/c/14444/1/tests/stress/test_acid_stress.py@47
PS1, Line 47: def run_tasks(tasks):
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/14444/1/tests/stress/test_acid_stress.py@191
PS1, Line 191: n
flake8: E713 test for membership should be 'not in'


http://gerrit.cloudera.org:8080/#/c/14444/1/tests/stress/test_acid_stress.py@244
PS1, Line 244: x
flake8: E501 line too long (113 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/14444/1/tests/stress/test_acid_stress.py@245
PS1, Line 245: e
flake8: E501 line too long (128 > 90 characters)



--
To view, visit http://gerrit.cloudera.org:8080/14444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I066652bfa7d924742af01aef8df4512e00620c7d
Gerrit-Change-Number: 14444
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Oct 2019 11:40:00 +0000
Gerrit-HasComments: Yes

Reply via email to