Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14471 )
Change subject: Fix webserver's use of sq_printf/sq_write ...................................................................... Fix webserver's use of sq_printf/sq_write Previously, the webserver used multiple calls to sq_printf and sq_write when sending most responses. This can lead to a bad interaction between Nagle's algorithm and TCP delayed acks which can add significant latency to RTT. This patch modifies the SendResponse() function to buffer the entire response and send it in a single sq_write call. Testing: - Ran all existing webserver tests. Change-Id: I343ae83d6324bc710e4cf96d66975a7c9694706f Reviewed-on: http://gerrit.cloudera.org:8080/14471 Reviewed-by: Adar Dembo <a...@cloudera.com> Reviewed-by: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M be/src/util/webserver.cc 1 file changed, 16 insertions(+), 9 deletions(-) Approvals: Adar Dembo: Looks good to me, but someone else must approve Thomas Tauber-Marshall: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/14471 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I343ae83d6324bc710e4cf96d66975a7c9694706f Gerrit-Change-Number: 14471 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
