Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14511 )
Change subject: IMPALA-9019: fix runtime filter propagation with mt_dop ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/14511/4/be/src/exec/partitioned-hash-join-builder.cc File be/src/exec/partitioned-hash-join-builder.cc: http://gerrit.cloudera.org:8080/#/c/14511/4/be/src/exec/partitioned-hash-join-builder.cc@101 PS4, Line 101: // Skip over filters that are not produced by this instance of the join. > Maybe worth expanding slightly on why this could be the case (I think its j Done http://gerrit.cloudera.org:8080/#/c/14511/4/be/src/runtime/coordinator-filter-state.h File be/src/runtime/coordinator-filter-state.h: http://gerrit.cloudera.org:8080/#/c/14511/4/be/src/runtime/coordinator-filter-state.h@153 PS4, Line 153: boost::shared_mutex lock; The locks were just moved from Coordinator, there isn't a change in the protocol. Agree this is confusing though. > we take it as a shared_mutex. Unless I'm missing something, even before your > change we never take this lock exclusively. .lock()/unlock() acquires exclusive ownership of shared_mutex, so lock_guard acquires exclusive ownership. shared_lock acquires shared ownership. That said, this is all counterintuitive and it's not obvious why it's correct so I added a comment where it's acquired and added notes in a few more places. http://gerrit.cloudera.org:8080/#/c/14511/4/be/src/runtime/coordinator-filter-state.h@156 PS4, Line 156: filter_routing_table_ > update Done http://gerrit.cloudera.org:8080/#/c/14511/4/be/src/runtime/coordinator.h File be/src/runtime/coordinator.h: http://gerrit.cloudera.org:8080/#/c/14511/4/be/src/runtime/coordinator.h@386 PS4, Line 386: boost::scoped_ptr > std::unique_ptr? Done. Also updated other instances to make this file consistent. -- To view, visit http://gerrit.cloudera.org:8080/14511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26e3628a982d5d9b8b24eb96b28aff11f8aa6669 Gerrit-Change-Number: 14511 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 21 Oct 2019 20:07:38 +0000 Gerrit-HasComments: Yes
