Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14433 )
Change subject: IMPALA-7504/KUDU-2979 ParseKerberosPrincipal() should use krb5_parse_name() instead ...................................................................... Patch Set 6: (3 comments) Thanks for this update http://gerrit.cloudera.org:8080/#/c/14433/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14433/5//COMMIT_MSG@21 PS5, Line 21: format principal, new error code is 2 instead of original 112 > What kind of end-to-end test? The one included in impala-private-parameteri yes, maybe there's a better name but I think this name is generally understood http://gerrit.cloudera.org:8080/#/c/14433/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14433/6//COMMIT_MSG@19 PS6, Line 19: Add two authentication-test Add two tests to authentication-test http://gerrit.cloudera.org:8080/#/c/14433/6/be/src/rpc/authentication-test.cc File be/src/rpc/authentication-test.cc: http://gerrit.cloudera.org:8080/#/c/14433/6/be/src/rpc/authentication-test.cc@200 PS6, Line 200: EXPECT_ERROR(sa.InitKerberos(" ", "/etc/hosts"), 2); This says we will get an error, but do we know it is the right error? We should check the return code or message or something more specific -- To view, visit http://gerrit.cloudera.org:8080/14433 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e64ebdc10f102dbdc5b87f6fe3f2a0310b1be24 Gerrit-Change-Number: 14433 Gerrit-PatchSet: 6 Gerrit-Owner: Xiaomeng Zhang <xiaom...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Xiaomeng Zhang <xiaom...@cloudera.com> Gerrit-Comment-Date: Wed, 23 Oct 2019 17:03:19 +0000 Gerrit-HasComments: Yes
