Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14539 )
Change subject: IMPALA-8995: Fix synchronization in dequeue thread ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14539/1/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/14539/1/be/src/scheduling/admission-controller.cc@1375 PS1, Line 1375: dequeue_cv_.Wait(lock); > I feel like this usage pattern of condition variables is really asking for great suggestion, done. -- To view, visit http://gerrit.cloudera.org:8080/14539 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91080ce54e59cc7e6361f7c50d6b2156a8a180c8 Gerrit-Change-Number: 14539 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 24 Oct 2019 20:21:06 +0000 Gerrit-HasComments: Yes
