Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14549 )
Change subject: IMPALA-9095: Alter table events generated by renames should apply renames properly. ...................................................................... Patch Set 2: (1 comment) The patch makes sense to me. I can give a +2 after modifying the log. http://gerrit.cloudera.org:8080/#/c/14549/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/14549/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1964 PS2, Line 1964: public boolean renameTableIfExists(TTableName oldTableName, The debug log in MetastoreEvents#process() is stale now. It says "Did not remove old table to rename table {} to {} since it does not exist anymore" if we return false here. -- To view, visit http://gerrit.cloudera.org:8080/14549 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5bf46a75cd872aba268e15dd7c02c2cb46d64890 Gerrit-Change-Number: 14549 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Fri, 25 Oct 2019 23:35:43 +0000 Gerrit-HasComments: Yes
