Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14576 )
Change subject: IMPALA-9047: Bump CDP_BUILD_NUMBER to 1471450 ...................................................................... Patch Set 1: (2 comments) A couple comments on your commit comment, but I think otherwise, this seems reasonable. http://gerrit.cloudera.org:8080/#/c/14576/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14576/1//COMMIT_MSG@9 PS1, Line 9: Some test cases would fail : due to this change. Specifically, some Ranger related E2E tests and FE : tests would fail when we are using a newer version of Ranger (i.e., : ranger-2.0.0.7.0.2.0-50 instead of ranger-1.2.0.7.1.0.0-33) due to the : changes to the default Ranger policies described at : https://issues.apache.org/jira/browse/RANGER-2536. I would describe this as the new GBN having a Ranger upgrade from 1.2 to 2.0. Something like: The new GBN upgrades Ranger from 1.2 to 2.0, which includes the change to the default Ranger policies describe in https://issues.apache.org/jira/browse/RANGER-2536. The Ranger tests fail, because they assume the older behavior. http://gerrit.cloudera.org:8080/#/c/14576/1//COMMIT_MSG@25 PS1, Line 25: Moreover, two HMS related E2E tests in test_hms_integration.py fail when : we are using a newer version of Hive (i.e., hive-3.1.2000.7.0.2.0-50 : instead of hive-2.1.1 by setting USE_CDP_HIVE to true when building : Impala). To address this issue, this patch temporarily skips those tests. USE_CDP_HIVE=true is a known configuration that uses Hive 3. The difference here is not a difference between Hive 2 and Hive 3, but between this latest Hive 3 and Hive 3 from the previous GBN. The behavior has permanently changed, so the skip is not temporary. I think I would drop this paragraph, and add a sentence to the start of the next paragraph that the new CDP GBN contains HIVE-22046. I would also include a line saying this is IMPALA-8842 part 2. So, this would end up looking like: IMPALA-8842 part 2: (Hive3) Use 'engine' field in HMS stat API The new CDP GBN includes the fix for HIVE-22046. HIVE-22046 added 'engine' column... (rest of paragraph) -- To view, visit http://gerrit.cloudera.org:8080/14576 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I962423cf202ad632b5817669500b3e3479f1a454 Gerrit-Change-Number: 14576 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Wed, 30 Oct 2019 00:36:57 +0000 Gerrit-HasComments: Yes
