Jiawei Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14589 )
Change subject: IMPALA-9105: Catalog debug page top-n table has a URL generation issue ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/14589/1/www/catalog.tmpl File www/catalog.tmpl: http://gerrit.cloudera.org:8080/#/c/14589/1/www/catalog.tmpl@42 PS1, Line 42: <td> > Oops! Yeah, I think someone accidentally deleted this. http://gerrit.cloudera.org:8080/#/c/14589/1/www/catalog.tmpl@47 PS1, Line 47: <a href="{{ __common__.host-url }}/catalog_object?object_type=TABLE&object_name={{name}}">{{name}}</a> > Is {{fqtn}} empty here causing the problem? Looks like we still use {{fqtn} Yes, fqtn empty caused the issue. The problem is that these "Top-n" tables are passed in a different function in CatalogServer::GetCatalogUsage. And we did not pass fqtn there. -- To view, visit http://gerrit.cloudera.org:8080/14589 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If7416c79baf2e78d6790995e97d9802ec7a8cc37 Gerrit-Change-Number: 14589 Gerrit-PatchSet: 1 Gerrit-Owner: Jiawei Wang <jiawei.w...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jiawei Wang <jiawei.w...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Thu, 31 Oct 2019 03:34:17 +0000 Gerrit-HasComments: Yes
