Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14600 )
Change subject: IMPALA-9109: Add top-k metadata loading ranking on catalogd UI ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Except for one small issue, the change looks good http://gerrit.cloudera.org:8080/#/c/14600/3/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/14600/3/tests/webserver/test_web_pages.py@378 PS3, Line 378: high_filecount_tbls = response_json["longest_loading_tables"] nit: Could you change the variable name? -- To view, visit http://gerrit.cloudera.org:8080/14600 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9305a867d7053cde9acc42dae6e47ee440f1a8bf Gerrit-Change-Number: 14600 Gerrit-PatchSet: 3 Gerrit-Owner: Jiawei Wang <jiawei.w...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jiawei Wang <jiawei.w...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com> Gerrit-Comment-Date: Fri, 01 Nov 2019 11:44:09 +0000 Gerrit-HasComments: Yes
