Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13882 )
Change subject: IMPALA-7984: Port runtime filter from Thrift RPC to KRPC ...................................................................... Patch Set 27: (3 comments) http://gerrit.cloudera.org:8080/#/c/13882/27/be/src/util/min-max-filter.cc File be/src/util/min-max-filter.cc: http://gerrit.cloudera.org:8080/#/c/13882/27/be/src/util/min-max-filter.cc@a696 PS27, Line 696: Don't remove this comment http://gerrit.cloudera.org:8080/#/c/13882/27/be/src/util/min-max-filter.cc@a701 PS27, Line 701: Don't remove this comment http://gerrit.cloudera.org:8080/#/c/13882/27/be/src/util/min-max-filter.cc@a704 PS27, Line 704: Don't remove this. I'm surprised this isn't causing any test failures, since we should be hitting the DCHECK below now. -- To view, visit http://gerrit.cloudera.org:8080/13882 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b394796d250286510e157ae326882bfc01d387a Gerrit-Change-Number: 13882 Gerrit-PatchSet: 27 Gerrit-Owner: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Tue, 05 Nov 2019 01:20:37 +0000 Gerrit-HasComments: Yes
