Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14636 )
Change subject: IMPALA-9117, IMPALA-7726: Fixed a few unit tests for ABFS ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14636/1/tests/common/skip.py File tests/common/skip.py: http://gerrit.cloudera.org:8080/#/c/14636/1/tests/common/skip.py@78 PS1, Line 78: file_or_folder_name_ends_with_period = pytest.mark.skipif(IS_ABFS, : reason="ABFS does not support file / directories that end with a period") > Will we still need this when we have the change in IMPALA-8557? Or is this Yeah we will still need this even after fixing IMPALA-8557. ABFS in general just does not allow files / folders to end in a period. There are some tests that write files / folder that end in a period: https://github.com/apache/impala/blob/master/testdata/workloads/functional-query/queries/QueryTest/insert.test#L433 -- To view, visit http://gerrit.cloudera.org:8080/14636 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I18ae5b0f7de6aa7628a1efd780ff30a0cc3c5285 Gerrit-Change-Number: 14636 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Comment-Date: Tue, 05 Nov 2019 22:31:58 +0000 Gerrit-HasComments: Yes
