Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14632 )

Change subject: IMPALA-9126: part 1: hash join build partition cleanup
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/14632/4/be/src/exec/partitioned-hash-join-node.cc
File be/src/exec/partitioned-hash-join-node.cc:

http://gerrit.cloudera.org:8080/#/c/14632/4/be/src/exec/partitioned-hash-join-node.cc@339
PS4, Line 339:     if (state_ == PROBING_SPILLED_PARTITION && 
NeedToProcessUnmatchedBuildRows(join_op_)) {
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/14632/4/be/src/exec/partitioned-hash-join-node.cc@1154
PS4, Line 1154:     hash_tbl_iterator_ = 
output_build_partitions_.front()->hash_tbl()->FirstUnmatched(ht_ctx_.get());
line too long (101 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/14632
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife8d0fa5dd14c7d3f3d726dd38c07d8cbceabadb
Gerrit-Change-Number: 14632
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Nov 2019 14:31:37 +0000
Gerrit-HasComments: Yes

Reply via email to