Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14707 )
Change subject: IMPALA-9081: fix mt_dop validation tests ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/14707/5/fe/src/main/java/org/apache/impala/planner/Planner.java File fe/src/main/java/org/apache/impala/planner/Planner.java: http://gerrit.cloudera.org:8080/#/c/14707/5/fe/src/main/java/org/apache/impala/planner/Planner.java@133 PS5, Line 133: !RuntimeEnv.INSTANCE.isTestEnv() > Out of curiosity, why do we do this? We have planner tests that verify plan Yeah exactly, the PARALLELPLANS with the join build sink aren't executable, but we want to continue testing the planner code. -- To view, visit http://gerrit.cloudera.org:8080/14707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e8823c562395e13f318d1ad6eed883d2d9d771f Gerrit-Change-Number: 14707 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 15 Nov 2019 18:32:28 +0000 Gerrit-HasComments: Yes
