Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14690 )
Change subject: IMPALA-9146: Add a configurable limit for the size of broadcast input. ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/14690/2/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/14690/2/be/src/service/query-options.cc@914 PS2, Line 914: ParseMemValue(value, "broadcast bytes limit for join operations", &broadcast_bytes_limit)); line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/14690/2/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: http://gerrit.cloudera.org:8080/#/c/14690/2/common/thrift/ImpalaService.thrift@488 PS2, Line 488: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/14690/2/common/thrift/ImpalaService.thrift@489 PS2, Line 489: // The max number of estimated bytes eligible for a Broadcast operation during a join. line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/14690/2/common/thrift/ImpalaService.thrift@490 PS2, Line 490: // If the planner thinks the total bytes sent to all destinations of a broadcast exchange line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/14690/2/common/thrift/ImpalaService.thrift@491 PS2, Line 491: // will exceed this limit, it will not consider a broadcast and instead fall back on a line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/14690/2/fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java File fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java: http://gerrit.cloudera.org:8080/#/c/14690/2/fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java@861 PS2, Line 861: Collections.<PlannerTestOption>emptySet()); tab used for whitespace -- To view, visit http://gerrit.cloudera.org:8080/14690 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe5639ca38acb72e0194aa80bc6ebb6cafb2acd9 Gerrit-Change-Number: 14690 Gerrit-PatchSet: 2 Gerrit-Owner: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Sat, 16 Nov 2019 20:12:29 +0000 Gerrit-HasComments: Yes
