Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/14059 )
Change subject: IMPALA-8863: Add support to run tests over HTTP/HS2 ...................................................................... Patch Set 27: (7 comments) http://gerrit.cloudera.org:8080/#/c/14059/26/be/src/exec/blocking-plan-root-sink.cc File be/src/exec/blocking-plan-root-sink.cc: http://gerrit.cloudera.org:8080/#/c/14059/26/be/src/exec/blocking-plan-root-sink.cc@147 PS26, Line 147: VLOG_QUERY << "Fetch timed out"; > maybe "Fetch timed out" to be more specific? Done http://gerrit.cloudera.org:8080/#/c/14059/26/tests/hs2/test_hs2.py File tests/hs2/test_hs2.py: http://gerrit.cloudera.org:8080/#/c/14059/26/tests/hs2/test_hs2.py@43 PS26, Line 43: # direct access to the TOpenSessionReq parameters. > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/14059/26/tests/hs2/test_hs2.py@54 PS26, Line 54: close_session_req.sessionHandle = session.sessionHandle > Do we want the context manager to throw an exception if closing the session This code already throws anything that comes out of check_response, i.e. AssertionError. Should we catch it and rewrite it here? tests/hs2/test_hs2.py:173: in test_open_session_empty_user "Unable to delegate using empty proxy username.") /usr/lib/python2.7/contextlib.py:24: in __exit__ self.gen.next() tests/hs2/test_hs2.py:55: in ScopedSession HS2TestSuite.check_response(hs2_client.CloseSession(close_session_req)) tests/hs2/hs2_test_suite.py:131: in check_response assert response.status.statusCode == expected_status_code E assert 3 == 0 E + where 3 = 3 E + where 3 = TStatus(errorCode=None, errorMessage='Invalid session id: 2d4be1a925222f89:9a9b07c761d056b4\n', sqlState='HY000', infoMessages=None, statusCode=3).statusCode E + where TStatus(errorCode=None, errorMessage='Invalid session id: 2d4be1a925222f89:9a9b07c761d056b4\n', sqlState='HY000', infoMessages=None, statusCode=3) = TStatus(errorCode=None, errorMessage='Invalid session id: 2d4be1a925222f89:9a9b07c761d056b4\n', sqlState='HY000', infoMessages=None, statusCode=3) E + where TStatus(errorCode=None, errorMessage='Invalid session id: 2d4be1a925222f89:9a9b07c761d056b4\n', sqlState='HY000', infoMessages=None, statusCode=3) = TCloseSessionResp(status=TStatus(errorCode=None, errorMessage='Invalid session id: 2d4be1a925222f89:9a9b07c761d056b4\n', sqlState='HY000', infoMessages=None, statusCode=3)).status http://gerrit.cloudera.org:8080/#/c/14059/26/tests/hs2/test_hs2.py@56 PS26, Line 56: > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/14059/26/tests/hs2/test_hs2.py@170 PS26, Line 170: > flake8: E502 the backslash is redundant between brackets Done http://gerrit.cloudera.org:8080/#/c/14059/26/tests/hs2/test_hs2.py@579 PS26, Line 579: > flake8: E501 line too long (91 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/14059/27/tests/hs2/test_hs2.py File tests/hs2/test_hs2.py: http://gerrit.cloudera.org:8080/#/c/14059/27/tests/hs2/test_hs2.py@582 PS27, Line 582: e > flake8: E122 continuation line missing indentation or outdented Done -- To view, visit http://gerrit.cloudera.org:8080/14059 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7156558071781378fcb9c8941c0f4dd82eb0d018 Gerrit-Change-Number: 14059 Gerrit-PatchSet: 27 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 19 Nov 2019 01:03:50 +0000 Gerrit-HasComments: Yes
