Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14741 )
Change subject: IMPALA-9165: Add timeout for create-load-data.sh ...................................................................... Patch Set 1: (2 comments) Made some changes to the script's argument parsing to add a script_name to use in debugging messages / filenames. http://gerrit.cloudera.org:8080/#/c/14741/1/bin/script-timeout-check.sh File bin/script-timeout-check.sh: http://gerrit.cloudera.org:8080/#/c/14741/1/bin/script-timeout-check.sh@74 PS1, Line 74: --step "test_run" > does this parameter, or the --phase parameter need to be changed depending Good point, added a script_name argument to this script so that we can have better messages / filenames. http://gerrit.cloudera.org:8080/#/c/14741/1/testdata/bin/create-load-data.sh File testdata/bin/create-load-data.sh: http://gerrit.cloudera.org:8080/#/c/14741/1/testdata/bin/create-load-data.sh@106 PS1, Line 106: minute > nit: minutes Done -- To view, visit http://gerrit.cloudera.org:8080/14741 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19d76bd8850c7d4b5affff4d21f32d8715a382c6 Gerrit-Change-Number: 14741 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Comment-Date: Tue, 19 Nov 2019 20:07:56 +0000 Gerrit-HasComments: Yes
