Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14740 )
Change subject: IMPALA-8867: Further deflake test_auto_scaling ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14740/1/tests/custom_cluster/test_auto_scaling.py File tests/custom_cluster/test_auto_scaling.py: http://gerrit.cloudera.org:8080/#/c/14740/1/tests/custom_cluster/test_auto_scaling.py@104 PS1, Line 104: min_query_rate = 1.1 * EXECUTOR_SLOTS I looked through the failures for this, and I've seen a couple failures on an older Centos 6 machine that was slightly below this: custom_cluster/test_auto_scaling.py:116: in test_single_workload assert max_query_rate >= min_query_rate, "Query rate did not reach %s within %s " \ E AssertionError: Query rate did not reach 3.6 within 45 s. Maximum was 3.2. Cluster size is 5. E assert 3.2000000000000002 >= 3.5999999999999996 That's the lowest I saw it go in the failures I reviewed. (Most of the current failures are above 3.3 and your fix would be good.) Would a 1.05 multiplier be ok? -- To view, visit http://gerrit.cloudera.org:8080/14740 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I29808982cc6226152c544cb99f76961b582975a7 Gerrit-Change-Number: 14740 Gerrit-PatchSet: 1 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Comment-Date: Tue, 19 Nov 2019 22:05:54 +0000 Gerrit-HasComments: Yes
