Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14716 )
Change subject: IMPALA-9126: part 2: no hj probe structures in build ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/14716/4/be/src/exec/partitioned-hash-join-builder.cc File be/src/exec/partitioned-hash-join-builder.cc: http://gerrit.cloudera.org:8080/#/c/14716/4/be/src/exec/partitioned-hash-join-builder.cc@414 PS4, Line 414: bool need_read_buffer = ht_ctx_->level() > 0; I thought this was a bug, because we need a read buffer when we're probing a single spilled partition, even if that partition's level is 0. But actually it works for a non-obvious reason - we don't currently call this function when we're probing a single spilled partition. Changed the code around so this is more explicit. -- To view, visit http://gerrit.cloudera.org:8080/14716 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0065f7f44f44f02b7616b1f694178ca42341c42d Gerrit-Change-Number: 14716 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 19 Nov 2019 22:44:57 +0000 Gerrit-HasComments: Yes
