Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14690 )
Change subject: IMPALA-9146: Add a configurable limit for the size of broadcast input. ...................................................................... Patch Set 6: (2 comments) I'm ready to +2 except for a couple of minor things http://gerrit.cloudera.org:8080/#/c/14690/6/fe/src/test/java/org/apache/impala/planner/PlannerTest.java File fe/src/test/java/org/apache/impala/planner/PlannerTest.java: http://gerrit.cloudera.org:8080/#/c/14690/6/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@1017 PS6, Line 1017: runPlannerTestFile("broadcast-bytes-limit-hint", "tpch_parquet", options); Optional: you could probably put this test in the same file as the previous one, since it uses all the same settings. http://gerrit.cloudera.org:8080/#/c/14690/6/testdata/workloads/functional-planner/queries/PlannerTest/broadcast-bytes-limit-hint.test File testdata/workloads/functional-planner/queries/PlannerTest/broadcast-bytes-limit-hint.test: http://gerrit.cloudera.org:8080/#/c/14690/6/testdata/workloads/functional-planner/queries/PlannerTest/broadcast-bytes-limit-hint.test@3 PS6, Line 3: # greater than broadcast_bytes_limit because the query has a nit: trailing whitespace. The bot ignores .test files, but would be best to avoid. -- To view, visit http://gerrit.cloudera.org:8080/14690 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe5639ca38acb72e0194aa80bc6ebb6cafb2acd9 Gerrit-Change-Number: 14690 Gerrit-PatchSet: 6 Gerrit-Owner: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 20 Nov 2019 16:56:52 +0000 Gerrit-HasComments: Yes
