Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14720 )
Change subject: IMPALA-9104: Support retrieval of PK/FK information through impala-hs2-server. ...................................................................... Patch Set 8: Code-Review+1 > (13 comments) > > The developer docs page says clang can be used only with the C++ > part of the code. I was manually doing this and still miss a few > code style errors. Clang documentation says it can be used for Java > too. Maybe I should try and modify our clang tool to work with > Java. Thank you for catching these errors. Oh, I don't think there's any reason why you can't run clang-format as is on the Java parts of Impala (I do it all the time). To be clear, you should think of the clang-format output as a guideline, as there will be some places that it differs from our preferred style, so always feel free to ignore it if its suggestions differ from the style of the surrounding code. -- To view, visit http://gerrit.cloudera.org:8080/14720 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8942dfbbd4a3be244eed1c61ac2ce17069960477 Gerrit-Change-Number: 14720 Gerrit-PatchSet: 8 Gerrit-Owner: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Wed, 20 Nov 2019 18:22:19 +0000 Gerrit-HasComments: No
