Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14744 )
Change subject: IMPALA-6894: Use an internal representation of query states in ClientRequestState ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/14744/3/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/14744/3/be/src/service/client-request-state.cc@506 PS3, Line 506: UpdateNonErrorExecState(ExecState::PENDING); This will actually mark the query pending even if the async-exec-thread creation failed. I dont think this should be a problem though because there is no condition specified on that state that assumes otherwise. -- To view, visit http://gerrit.cloudera.org:8080/14744 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ce70bd2e964b309ebfc9d6ff6d900485db4d630 Gerrit-Change-Number: 14744 Gerrit-PatchSet: 3 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Fri, 22 Nov 2019 19:21:02 +0000 Gerrit-HasComments: Yes
