David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/14788 )
Change subject: IMPALA-9157: Make helper function exec_local_command python 2.6 compatible ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/14788/1/lib/python/impala_py_lib/helpers.py File lib/python/impala_py_lib/helpers.py: http://gerrit.cloudera.org:8080/#/c/14788/1/lib/python/impala_py_lib/helpers.py@43 PS1, Line 43: if retcode: > I'm fine either way - seems like valid cleanup but we don't need it to fix Fair enough. Another patch can always be submitted for that minor cleanup. -- To view, visit http://gerrit.cloudera.org:8080/14788 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I928a4df9dc883e8e801a42ead14ec7875169d4ae Gerrit-Change-Number: 14788 Gerrit-PatchSet: 3 Gerrit-Owner: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 22 Nov 2019 22:00:35 +0000 Gerrit-HasComments: Yes
