Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14792 )
Change subject: IMPALA-9188: Composite primary keys should use same constraint name ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Carrying +2. http://gerrit.cloudera.org:8080/#/c/14792/1/fe/src/main/java/org/apache/impala/analysis/TableDef.java File fe/src/main/java/org/apache/impala/analysis/TableDef.java: http://gerrit.cloudera.org:8080/#/c/14792/1/fe/src/main/java/org/apache/impala/analysis/TableDef.java@498 PS1, Line 498: ll primary key > nit, adding a comment here would be useful Done -- To view, visit http://gerrit.cloudera.org:8080/14792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a91658945b0355753c3cf05be195757b37edaf4 Gerrit-Change-Number: 14792 Gerrit-PatchSet: 2 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Mon, 25 Nov 2019 17:56:10 +0000 Gerrit-HasComments: Yes